Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass OutputFileNamesWithoutVersion to PackCommandRunner.GetOutputFileName for correct prediction of outputs #5720

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

inthemedium
Copy link

@inthemedium inthemedium commented Mar 26, 2024

Pass OutputFileNamesWithoutVersion to PackCommandRunner.GetOutputFileName for correct prediction of outputs

Bug

Fixes:
NuGet/Home#12644

Regression? Last working version:
No.

Description

Pass OutputFileNamesWithoutVersion to PackCommandRunner.GetOutputFileName for correct prediction of outputs

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@inthemedium inthemedium requested a review from a team as a code owner March 26, 2024 19:55
@dotnet-policy-service dotnet-policy-service bot added the Community PRs created by someone not in the NuGet team label Mar 26, 2024
@inthemedium inthemedium changed the title Pass OutputFileNamesWithoutVersion to GetOutputFileName for correct prediction of outputs Pass OutputFileNamesWithoutVersion to PackCommandRunner.GetOutputFileName for correct prediction of outputs Mar 26, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 90 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@jeffkl jeffkl removed the Status:No recent activity No recent activity. label May 28, 2024
@jeffkl
Copy link
Contributor

jeffkl commented May 28, 2024

@inthemedium sorry for the delay. I've rebased your branch since our code base has had a lot of CI improvements. You'll need to pull the changes from your remote. Do you think you could add a unit test to https://github.com/NuGet/NuGet.Client/blob/dev/test/NuGet.Core.Tests/NuGet.Build.Tasks.Pack.Test/PackTaskTests.cs? This would help validate the change and ensure it doesn't regress later.

Copy link
Contributor

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 90 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@dotnet-policy-service dotnet-policy-service bot added the Status:No recent activity No recent activity. label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PRs created by someone not in the NuGet team Status:No recent activity No recent activity.
Projects
None yet
3 participants