-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass OutputFileNamesWithoutVersion
to PackCommandRunner.GetOutputFileName
for correct prediction of outputs
#5720
base: dev
Are you sure you want to change the base?
Conversation
OutputFileNamesWithoutVersion
to PackCommandRunner.GetOutputFileName
for correct prediction of outputs
src/NuGet.Core/NuGet.Build.Tasks.Pack/GetPackOutputItemsTask.cs
Outdated
Show resolved
Hide resolved
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 90 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
@inthemedium sorry for the delay. I've rebased your branch since our code base has had a lot of CI improvements. You'll need to pull the changes from your remote. Do you think you could add a unit test to https://github.com/NuGet/NuGet.Client/blob/dev/test/NuGet.Core.Tests/NuGet.Build.Tasks.Pack.Test/PackTaskTests.cs? This would help validate the change and ensure it doesn't regress later. |
This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 90 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch. |
Pass
OutputFileNamesWithoutVersion
toPackCommandRunner.GetOutputFileName
for correct prediction of outputsBug
Fixes:
NuGet/Home#12644
Regression? Last working version:
No.
Description
Pass
OutputFileNamesWithoutVersion
toPackCommandRunner.GetOutputFileName
for correct prediction of outputsPR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation