Respect ReferenceOutputAssembly when packing a CSPROJ #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have manually tested the scenario. Plus, ran all the tests |
|
|
1 similar comment
|
|
…d in the package along with tests
construct the test msbuild project files. 1. Tested that the added tests passed 2. Tested manually that if a project reference has the element <ReferenceOutputAssembly>false</ReferenceOutputAssembly>, it is ignored during 'nuget.exe pack -IncludeReferencedProjects'
deepakaravindr
force-pushed
the
chandramouleswaran-dev
branch
from
9ad6bf5
to
c3cee71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[from @chandramouleswaran. PR and the text below. I have fixed the tests to use XElement and existing Util helper methods]
This PR addresses - NuGet/Home#1540
Basically, we do not want to include assemblies of project references which are only used to help resolving build dependencies.
For example: I might have a .proj file which does say VHD creation but I do not want its output to be a part of the package.
This can be done using ReferenceOutputAssembly being false which is a standard now. I have also added tests for the same.
@yishaigalatzer @emgarten @zhili1208