Add --legacy-packages-directory to Xplat restore #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,6 +94,8 @@ internal static class RestoreCommand | |||
|
|
|||
| using (var cacheContext = new SourceCacheContext()) | |||
| { | |||
| var legacyPackagesDirectory = legacyPackagesDirectoryOption.HasValue(); | |||
There was a problem hiding this comment.
nit. isLegacyPackagesDirectory
|
xplat restore is dead 💀 |
|
lgtm |
|
Looks great! 👏 |
joelverhagen
force-pushed
the
jver-lowerswitch
branch
from
482febc
to
737af82
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new switch
--legacy-packages-directorytoNuGet.CommandLine.Xplat(i.e.dotnet restore) which allows the caller to restore to the packages folder folders with original case ID and version.Since the correct format of the global packages folder is
{root}/{lowercase-id}/{lowercase-version}, this is done by first restoring to lowercase folder names then, as a post-process step to the restore operation, copy the packages to{root}/{original-id}/{original-version}. This allows the legacy mode to be minimally invasive to the main restore operation.This command line option is part of a backwards compatibility story so that 1.0.0 Corehost can still find packages restored by newer version of NuGet.
Corehost reads a
.deps.jsonfile generated by .NET CLI. .NET CLI generates the.deps.jsonfile from theproject.lock.jsonfile that we write out. When the--legacy-packages-directoryswitch is passed, the lock file written out has thepathproperty of eachpackagelibrary converted from lowercase to original case.Next steps are modifying CLI to include the
pathproperty in the.deps.jsonfile and modifying Corehost to prefer thispathproperty over the concatenation of the library ID + library version.@emgarten @alpaix @rohit21agrawal @rrelyea