Properly dispose HttpWebResponse in SecurityPolicyTests (#5468) (#5475)

NuGet · Feb 14, 2018 · 22ea656 · 22ea656
1 parent e21bad6
commit 22ea656
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/tests/NuGetGallery.FunctionalTests/PackageCreation/SecurityPolicyTests.cs b/tests/NuGetGallery.FunctionalTests/PackageCreation/SecurityPolicyTests.cs
@@ -206,15 +206,17 @@ private async Task<string> CreateVerificationKey(string apiKey, string packageId
             request.Headers.Add(Constants.NuGetHeaderApiKey, apiKey);
             request.Headers.Add(Constants.NuGetHeaderClientVersion, "NuGetGallery.FunctionalTests");
 
-            var response = await request.GetResponseAsync() as HttpWebResponse;
-            Assert.NotNull(response);
-            Assert.Equal(HttpStatusCode.OK, response.StatusCode);
-
             string responseText;
-            using (var sr = new StreamReader(response.GetResponseStream()))
+            using (var response = await request.GetResponseAsync() as HttpWebResponse)
             {
-                responseText = await sr.ReadToEndAsync();
-            }
+                Assert.NotNull(response);
+                Assert.Equal(HttpStatusCode.OK, response.StatusCode);
+
+                using (var sr = new StreamReader(response.GetResponseStream()))
+                {
+                    responseText = await sr.ReadToEndAsync();
+                }
+            }                
 
             var json = JObject.Parse(responseText);
             var expiration = json.Value<DateTime>("Expires");
@@ -236,8 +238,10 @@ private async Task<HttpStatusCode> VerifyPackageKey(string apiKey, string packag
 
             try
             {
-                var response = await request.GetResponseAsync() as HttpWebResponse;
-                return response.StatusCode;
+                using (var response = await request.GetResponseAsync() as HttpWebResponse)
+                {
+                    return response.StatusCode;
+                }
             }
             catch (WebException e)
             {