Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In most browsers, users can get around block on reporting package bugs using the Prev and Next buttons. #1725

Closed
claycompton opened this issue Nov 9, 2013 · 2 comments

Comments

@claycompton
Copy link

  1. In any browser except Firefox, navigate to the Report Abuse page for an existing package (e.g. https://qa.nugettest.org/packages/jQuery/2.0.3/ReportAbuse )
  2. Select the reason "The package has a bug" from the dropdown. As expected, the other form elements will be disabled.
  3. Press the browser's previous page and next page buttons.

Result: On returning to the Report Abuse page, the other form elements will no longer be disabled. You can submit the form with this reason.
Expected: This should not be possible. I've filed a separate but to unify our handling of invalid reasons, but barring that, we should try to catch this scenario on return and re-disable the other elements on the page if "The package has a bug" is the currently-selected reason.

Contribution Notes

Contributed by @mgroves - This should be noted in the Change Log/Release Notes.

@analogrelay
Copy link
Contributor

I'll take a quick look in I7, but this is ripe for being deferred or pushed to Up For Grabs :). This is really just a way to reduce noise, not necessarily eliminate it.

@ghost ghost assigned analogrelay Dec 3, 2013
analogrelay added a commit that referenced this issue Feb 24, 2014
Fixes #1725 by using a selector instead of 'this', so reasonSelected wor...
@analogrelay analogrelay modified the milestones: v3.0.1, Up For Grabs Feb 24, 2014
@analogrelay
Copy link
Contributor

Fixed in #1884.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants