While uploading package, the entry can be added to database, even if the upload to blob storage fails

[bhuvak]

While doing package upload, the package is uploaded to blob and then the changes to database is commited. Since this is not a single atomic action, failure in the former doesn't guarentee abortion of the latter. We need to add more checks around it.

[bhuvak]

Looks like this is more likely to happen when we push packages using NuGet.exe command line.

While uploading packages from UI, changes to DB is made only after the packages gets pushed to blob(https://github.com/NuGet/NuGetGallery/blob/master/src/NuGetGallery/Controllers/PackagesController.cs#L888). Where as while uploading from command line, saving to DB is done before pushing file to blob. (https://github.com/NuGet/NuGetGallery/blob/master/src/NuGetGallery/Controllers/ApiController.cs#L277)

[johnataylor]

This sounds like a Pri 1. Bug for packages upload from the command line. Can you confirm?

[maartenba]

Was this one fixed?

[skofman1]

This is still relevant: https://github.com/NuGet/NuGetGallery/blob/master/src/NuGetGallery/Controllers/ApiController.cs#L328
@maartenba @qianjun22

[skofman1]

Was fixed.