Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog initialization should not rely on Exists semantics #2650

Open
johnataylor opened this issue Aug 29, 2015 · 0 comments
Open

Catalog initialization should not rely on Exists semantics #2650

johnataylor opened this issue Aug 29, 2015 · 0 comments

Comments

@johnataylor
Copy link
Member

Adding to the catalog has the additional behavior of checking for the existence of a catalog in the container and if it is not present then it creates one. This code presumes the "Exists" call on the Azure Storage SDK is always reliable.

It appears it might be better to not rely on this call (internally it relies on seeing a 404).

For now we should remove the "smarts" of checking for an existing catalog - at least in the AppendOnlyCatalog. The logic is just there to make the classes easier to use. In the production scenario, however, we always now explicitly whether we are appending to a catalog or whether we are starting a new one. We would do better to make this distinction explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant