Tilovell/1613 better handling of duplicate email addresses #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 2, 2013 11:50
…il address if there is already a conflicting email address.
…es instead of error pages. Update fact coverage of TheConfirmAction.
…d create duplicate confirmed addresses.
…es they will now see that their account can't be found instead of seeing a white screen of death.
claycompton
pushed a commit
that referenced
this pull request
Oct 3, 2013
…licateEmailAddresses Tilovell/1613 better handling of duplicate email addresses
| @@ -124,7 +124,7 @@ | |||
| <value>The username '{0}' is not available.</value> | |||
| </data> | |||
| <data name="UserNotFound" xml:space="preserve"> | |||
| <value>A user with the provided user name and password does not exist.</value> | |||
| <value>A unique user with that username or email address and password does not exist. Try logging on with your username if you were using an email address to log on.</value> | |||
There was a problem hiding this comment.
I like this for dealing with bad data, but can we also make the EmailAddress space unique? Not necessarily in this sprint, just as a general future thing.
There was a problem hiding this comment.
You mean find all the users with duplicate email addresses and change their addresses for them or something?
There was a problem hiding this comment.
Well, do we know if we even have any duplicates? If we do, I don't think there's much we can do about it, but if not, we could slap a UNIQUE constraint on the column :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #1613