Fixed #315 for realz, actually allowing log on with email. #355
Conversation
| @@ -149,7 +150,7 @@ public string GenerateApiKey(string username) | |||
|
|
|||
| public bool ChangePassword(string username, string oldPassword, string newPassword) | |||
There was a problem hiding this comment.
Can we change the username param to usernameOrEmail since we're allowing emails now?
There was a problem hiding this comment.
Will use usernameOrEmail as the parameter, to be consistent with others.
|
Some minor comments, but nothing impeding pushing it. |
|
When a user logs in with an email address what do we store in the Identity (email or username)? |
|
@osbornm It still returns a User, so that shouldn't change. |
|
Yeah, the controller still users User.Username for the auth token. |
|
@anglicangeek & @jeffhandley in that case shouldn't everything expect login take only the username? If username is the "authoritative" field. |
Fixed #315 for realz, actually allowing log on with email.
|
What why did the ChangeEmail thing change then????? |
|
Yeah, actually, why would change password ever use email? It's always done with a user that's logged in. |
|
We just need another method then, that doesn't fall back to email address. I'll add that. |
|
wait what? why does change password fail back to email address? login should set the user name and from then on out the whole site uses username not email? |
|
Addressed here: #356 |
No description provided.