Fix concurrent push test by disabling search hijacking on feed #3641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
approved these changes
Mar 10, 2017
| @@ -211,6 +211,7 @@ private static string GetPackagesAppearInFeedInOrderUrl(DateTime time, string ti | |||
| foreach (var version in versions) | |||
| { | |||
| var feedUrl = $"{UrlHelper.V2FeedRootUrl}/Packages?$filter=Id eq '{packageId}' and Version eq '{version}'" + | |||
| "and 1 eq 1" + // Disable search hijacking to get immediate results. | |||
There was a problem hiding this comment.
I think you can also use an orderby to prevent hijacking--it might look a little less goofy to do that. I know the URL used by PackagesInFeedAppearInOrder isn't hijacked.
There was a problem hiding this comment.
Depends if you want to have things sorted, right? This way basically means the caller doesn't care about the ordering.
shishirx34
approved these changes
Mar 10, 2017
joelverhagen
approved these changes
Mar 10, 2017
chenriksson
added a commit
that referenced
this pull request
Mar 27, 2017
* Revert "UpdateIsLatest concurrent unlist fix (#3695)" This reverts commit 551fd86. * Revert "Fix concurrent push test by disabling search hijacking on feed (#3641)" This reverts commit 00fb3fb. * Revert "IsLatest Fix: wrong connection string passed to retry context (#3632)" This reverts commit 1b6b5b0. * Revert "Fix #2514 - Use optimistic concurrency to prevent multiple UpdateIsLatest calls on same package (#3548)" This reverts commit 27ea9bc.
jozefizso
added a commit
to goit/NuGetGallery
that referenced
this pull request
Apr 20, 2017
…7.03.27 * tag 'v2017.03.27': (205 commits) Revert UpdateIsLatest optimistic concurrency changes (NuGet#3707) UpdateIsLatest concurrent unlist fix (NuGet#3695) Change telemetry time to use correct format (NuGet#3690) Fix typo of "publically" (NuGet#3636) Fix regression (NuGet#3667) Add credential to Register and RequestPasswordReset audits (NuGet#3666) Functional test for temp keys (NuGet#3664) Telemetry for temp keys (NuGet#3662) Temp keys implementation (NuGet#3563) (NuGet#3646) Extracting code: single type per file (NuGet#3644) Telemetry for package push (NuGet#3649) Upgrade to NuGet.* v4.0.0 dependencies (NuGet#3643) Fix concurrent push test by disabling search hijacking on feed (NuGet#3641) Fixing Package Description truncation (NuGet#3638) Fix Microsoft Account removal (NuGet#3639) Send e-mail when a new API key is created (NuGet#3634) IsLatest Fix: wrong connection string passed to retry context (NuGet#3632) Update WindowsAzure.Storage to 7.0.0 (NuGet#3633) Depend on signed version of Elmah (NuGet#3609) Move AzureEntityList and TableErrorLog to NuGetGallery.Core (NuGet#3607) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.