Fix issue with API header binding when running under a subdirectory #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternate fix would be to trim the request.ApplicationPath from the start of the URL before checking if it starts with "api" |
| @@ -10,7 +10,7 @@ public override IValueProvider GetValueProvider(ControllerContext controllerCont | |||
| var request = controllerContext.RequestContext.HttpContext.Request; | |||
|
|
|||
| // Use this value provider only if a route is located under "API" | |||
| if (request.Path.TrimStart('/').StartsWith("api", StringComparison.OrdinalIgnoreCase)) | |||
| if (request.Path.Contains("/api/")) | |||
There was a problem hiding this comment.
I think it might be safe to use the Controller as the discriminator. We could do:
if (controllerContext.Controller is ApiController)
{
// ...
}
There was a problem hiding this comment.
Ah, that's an even better idea.
|
I sent out a separate pull request with the fix #488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #409. The HttpHeaderValueProviderFactory only enables the HttpHeaderValueProvider if the URL starts with "/api". When running the NuGet Gallery under a subdirectory (eg. http://devlocal/nuget/), the URL will not start with /api and hence the value provider is not added correctly.