Fix for broken package delete #6642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agr
requested review from
joelverhagen,
loic-sharma,
xavierdecoster,
shishirx34,
ryuyu,
chenriksson,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
chenriksson
approved these changes
Nov 8, 2018
Updated tests to include All folders.
joelverhagen
approved these changes
Nov 8, 2018
scottbommarito
pushed a commit
that referenced
this pull request
Nov 9, 2018
* Package delete was broken with recent update. This fixes it. * Moved folder names into its own class. Updated tests to include All folders. * Added tests to verify all folders are covered by tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new folder to a list of known private folders.
Changed the default cache control to be not set.
Updated tests to include the new folder.
To prevent the issue in the future all folders were moved into their own class and added a test that makes sure
CloudBlobCoreFileStorageServiceFactshave all of them covered.