ManagePackageViewModel should not be dependent on DisplayPackageViewModel #6900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
chenriksson,
cristinamanum,
skofman1 and
zhhyu
joelverhagen
approved these changes
Feb 19, 2019
xavierdecoster
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
precursor to #6773
We decided that it was a bad idea to make the
ManagePackageViewModeldependent onDisplayPackageViewModelas it forcesDisplayPackageViewModelto store all information necessary to build theManagePackageViewModel, which complicates the performance of the page.ManagePackageViewModelwill need deprecation information for all versions, butDisplayPackageViewModelonly needs the selected package's deprecation information.I have kept the dependency on
ListItemPackageViewModelbecause it needs some of the fields on it, and I felt the model was lightweight enough for it not to be a big deal to reuse it.