Minor fixes to the GET DeleteSymbols endpoint #6937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
chenriksson,
cristinamanum,
skofman1 and
zhhyu
|
(Tests will be fixed after I pull in #6912.) |
scottbommarito
force-pushed
the
sb-deletesymbolsselectlist
branch
from
f916241
to
87056b8
Compare
shishirx34
approved these changes
Feb 26, 2019
loic-sharma
approved these changes
Feb 27, 2019
zhhyu
approved these changes
Feb 27, 2019
agr
reviewed
Feb 27, 2019
| .Select(p => p.LatestSymbolPackage()) | ||
| .Where(sp => sp != null && sp.StatusKey == PackageStatus.Available) | ||
| .Select(sp => new PackageViewModel(sp.Package)); | ||
| .Where(p => (p.LatestSymbolPackage()?.StatusKey ?? PackageStatus.Deleted) == PackageStatus.Available); |
There was a problem hiding this comment.
What's the point of ?? PackageStatus.Deleted? null by itself is not equal to any enum value.
There was a problem hiding this comment.
enums are ints internally, which means they don't support null.
Therefore, I must convert the null to a valid enum value before I can compare.
agr
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple fixes that were done while working on #6912 but moved to here because they are separate to it
Two issues fixed here:
DeleteSymbolsrequires all versions of the package but doesn't callFindPackagesByIdDeleteSymbolsusesSelectList(which uses reflection and dynamic objects) instead ofIEnumerable<SelectListItem>