Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add feature flag for banner #8527

Merged
merged 1 commit into from Apr 15, 2021
Merged

add feature flag for banner #8527

merged 1 commit into from Apr 15, 2021

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Apr 14, 2021 •
edited

Summary of the changes (in less than 80 characters):

add feature flag to display banner.

banner

Addresses #8525

@lyndaidaii lyndaidaii requested a review from a team as a code owner April 14, 2021 23:56
agr
agr approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@agr agr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add a banner screenshot to the PR.

joelverhagen
joelverhagen approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@lyndaidaii lyndaidaii merged commit 337ff6a into dev Apr 15, 2021
@agr agr mentioned this pull request Apr 17, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelverhagen joelverhagen joelverhagen approved these changes

@agr agr agr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lyndaidaii @joelverhagen @agr