Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created gird for new page layout of Display Package Page for redesign #8612

Merged
merged 2 commits into from Jun 1, 2021

Conversation

sophiamfavro
Copy link
Contributor

@sophiamfavro sophiamfavro commented May 28, 2021

Background

For the redesign of the display package page, the new layout follows this image
image

Solution

In order to achieve this I used Bootstraps grid feature to create this new layout. Here is the code needed to achieve this structure without any of the page content. Below it is the output that the code creates
image
image
I used this code as a guide for editing the DispayPackageV2.cshtml as to not impact the existing page. After completeing my changes, the page now looks like this
image
The mobile view looks like this
image
image

Testing

To check that my solution had worked I ran the page and

  • checked that there were no errors in the .js by looking at the console
  • collapsed the code so that only the row/column divs were shown and compared to the simplified structure code above
  • Inspected the page and hovered over the sections to see that all the content was in the correct column/row

Recommend using hide white spaces changes when reviewing

image

@sophiamfavro sophiamfavro requested a review from a team as a code owner May 28, 2021 17:26
Copy link
Contributor

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sophiamfavro sophiamfavro merged commit f027f98 into dev Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants