[TFM Display] Create model for badges and table from compatible frameworks. #8881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
reviewed
Nov 17, 2021
tests/NuGetGallery.Core.Facts/Frameworks/FrameworkCompatibilityServiceFacts.cs
Show resolved
Hide resolved
loic-sharma
reviewed
Nov 17, 2021
loic-sharma
reviewed
Nov 17, 2021
loic-sharma
reviewed
Nov 17, 2021
src/NuGetGallery.Core/Frameworks/PackageFrameworkCompatibilityTableData.cs
Show resolved
Hide resolved
loic-sharma
reviewed
Nov 17, 2021
src/NuGetGallery.Core/Frameworks/PackageFrameworkCompatibilityFactory.cs
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Nov 17, 2021
src/NuGetGallery.Core/Frameworks/PackageFrameworkCompatibilityFactory.cs
Outdated
Show resolved
Hide resolved
loic-sharma
reviewed
Nov 17, 2021
tests/NuGetGallery.Core.Facts/Frameworks/PackageFrameworkCompatibilityFactoryFacts.cs
Show resolved
Hide resolved
loic-sharma
reviewed
Nov 17, 2021
tests/NuGetGallery.Core.Facts/Frameworks/PackageFrameworkCompatibilityFactoryFacts.cs
Show resolved
Hide resolved
agr
reviewed
Nov 17, 2021
drewgillies
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Thank you, @dannyjdev! Looks great. Just a couple of things from me--solid tests, btw.
src/NuGetGallery.Core/Frameworks/PackageFrameworkCompatibilityFactory.cs
Outdated
Show resolved
Hide resolved
src/NuGetGallery.Core/Frameworks/PackageFrameworkCompatibilityFactory.cs
Outdated
Show resolved
Hide resolved
tests/NuGetGallery.Core.Facts/Frameworks/PackageFrameworkCompatibilityFactoryFacts.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This model will be used on the display page to create the table and badges for UI.
FrameworkCompatibilityServicewas updated to include a supported framework that is not on theSupportedFrameworkslist. This to include all package asset frameworks that we might not know of (but they are not used to get new computed frameworks, so no computation added here).PackageFrameworkCompatibilityFactorycreates the model that holds the badges and table ready to be displayed.Address: https://github.com/NuGet/Engineering/issues/3991.