-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[A11y] Adjusted homepage circuit board label sizes to accommodate text spacing #9059
Conversation
Do you know why we're using |
If we are to go with dynamic width approach, we also might need to update the image to move the "unique packages" box a little bit down to remove the chance of it overlapping with the "package downloads" one. |
Agree, I would check the padding solution if possible for dynamic increases in content and width. |
…xpansion, moved unique packages label down to allow more space once labels expand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the aesthetic side. I can't comment on the CSS.
Addresses #8988
Problem:
On the Home page, when text spacing is applied, the 'package versions' and 'unique packages' text overflows outside its container.
NOTE: I was told to use codepen.io to apply text spacing, but it can also be achieved by adding this to the stylesheet:
Regular home page:
After applying text spacing:
Fix:
To fix this, I made the label containers wider to accommodate the expanded text. The resulting UI changes seem minor to look at, but I'm happy to get additional feedback on that.
After the changes,
Regular home page:
After applying text spacing: