Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[README] Improve blockquote styling #9083

Merged
merged 1 commit into from
Apr 1, 2022
Merged

[README] Improve blockquote styling #9083

merged 1 commit into from
Apr 1, 2022

Conversation

lyndaidaii
Copy link
Contributor

@lyndaidaii lyndaidaii commented Apr 1, 2022

Addresses #8505

before:

Screenshot 2022-04-01 104023

after:
Screenshot 2022-04-01 104210

@lyndaidaii lyndaidaii requested a review from a team as a code owner April 1, 2022 00:35
@joelverhagen
Copy link
Member

The code change seems reasonable. I'll take a look once there is a before and after screenshot.

@lyndaidaii lyndaidaii merged commit 1cdf0b3 into dev Apr 1, 2022
@zhhyu
Copy link
Contributor

zhhyu commented Apr 1, 2022

Besides the font size, shouldn't we also tune the space between the two lines? I think it's too much compared to other elements.

@agr agr mentioned this pull request Apr 8, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants