Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL connection creation duration tracking #9086

Merged
merged 8 commits into from
Apr 8, 2022
Merged

SQL connection creation duration tracking #9086

merged 8 commits into from
Apr 8, 2022

Conversation

agr
Copy link
Contributor

@agr agr commented Apr 5, 2022

Added a client-side aggregated metric for SQL connection creation duration.

@agr agr requested a review from a team as a code owner April 5, 2022 19:32
Rename metric to include units.

Co-authored-by: Joel Verhagen <jver@microsoft.com>
shishirx34
shishirx34 previously approved these changes Apr 6, 2022
Copy link
Contributor

@shishirx34 shishirx34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for addressing any specific performance issues analysis?

zhhyu
zhhyu previously approved these changes Apr 8, 2022
@agr
Copy link
Contributor Author

agr commented Apr 8, 2022

@shishirx34, I want to get some insight into the ratio of sync/async calls and the duration of each.

@agr agr dismissed stale reviews from zhhyu and shishirx34 via 54f5b8d April 8, 2022 19:59
agr added 2 commits April 8, 2022 14:02
Testing both sync and async SQL creation duration metric
@agr agr merged commit cef94bf into dev Apr 8, 2022
@agr agr deleted the agr-duration branch April 8, 2022 22:56
@agr agr mentioned this pull request Apr 8, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants