Add section link support for READMEs #9193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you verify if internal section links work on markdown? |
|
Performed some validation and confirmed that the readme section links are functional. The current behavior when an internal link is hovered over: (The link displayed at the bottom of the screenshot shows the URL for the main package details page) The new behavior when an internal link is hovered over: (The link displayed at the bottom of the screenshot shows the URL for the selected section of the readme) The new behavior when an internal link is clicked: (The selected section is navigated to as expected) |
joelverhagen
approved these changes
Aug 22, 2022
lyndaidaii
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue where internal section links in a README do not link to the specified section, but instead take a user back to the top.
Addresses #8833