Use package's NormalizedVersion to create support requests #9285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewgillies
force-pushed
the
dg-sr-normalizedversion
branch
2 times, most recently
from
fc8e834
to
45d1baa
Compare
drewgillies
force-pushed
the
dg-sr-normalizedversion
branch
from
45d1baa
to
7bc8d16
Compare
| return string.Empty; | ||
| } | ||
|
|
||
| return string.IsNullOrEmpty(package.NormalizedVersion) ? Normalize(package.Version) : package.NormalizedVersion; |
There was a problem hiding this comment.
Can we query the DB and see if this case happens at all? Even when I first joined the team I remember seeing NormalizedVersion populated every time we need it.
There was a problem hiding this comment.
Have just queried. This case doesn't exist.
joelverhagen
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: https://github.com/NuGet/Engineering/issues/4637