Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TFM] net6.0-windows7.0 compatibility added. #9364

Merged
merged 1 commit into from Jan 30, 2023
Merged

[TFM] net6.0-windows7.0 compatibility added. #9364

merged 1 commit into from Jan 30, 2023

Conversation

dannyjdev
Copy link
Contributor

Description

We use NuGet client sdk in order to create a compatibility matrix for displaying TFMs on nuget.org. Currently there is no knowledge on nuget client sdk on what net5+ platform version exists (like net6.0-windows7.0) and they are not computed.

Changes

  • net6.0-windows7.0 compatibility has been hardcoded with known values.
  • This compatibility will only show if a package contains that specific TFM in their assets.

Screenshots

Before

After

Notes

  • Why doesn't these PR cover all the other versions?
    • We don't know the exhaustive compatibility on platform versions.
  • For further improvements we will need to collaborate with NuGet client and dotnet sdk: https://github.com/NuGet/Engineering/issues/4730.

Addresses: #9337

@dannyjdev dannyjdev requested a review from a team as a code owner January 26, 2023 22:03
@agr
Copy link
Contributor

agr commented Jan 26, 2023

Is there an issue on the client side about it? Please create or link it.

@dannyjdev dannyjdev merged commit 6f0bd1e into dev Jan 30, 2023
@dannyjdev dannyjdev deleted the dev-dj-net6windows7 branch January 30, 2023 21:09
@drewgillies drewgillies mentioned this pull request Feb 6, 2023
Closed
6 tasks
@zhhyu zhhyu mentioned this pull request Feb 8, 2023
Merged
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
@JoeRobich
Remove platform version when parsing NuGetFramework from TFM
af583c0 
- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
@JoeRobich
Merged PR 732978: Remove platform version when parsing NuGetFramework…
44f1d5e 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 11, 2023
@JoeRobich @brettfo
Merged PR 732978: Remove platform version when parsing NuGetFramework…
ebd7cb6 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 12, 2023
@JoeRobich @brettfo
Merged PR 732978: Remove platform version when parsing NuGetFramework…
7ffa2a0 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 12, 2023
@JoeRobich @brettfo
Merged PR 732978: Remove platform version when parsing NuGetFramework…
6606247 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 12, 2023
@JoeRobich @brettfo
Merged PR 732978: Remove platform version when parsing NuGetFramework…
02ffa1b 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 12, 2023
@JoeRobich @brettfo
Merged PR 732978: Remove platform version when parsing NuGetFramework…
2486aa4 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 13, 2023
@JoeRobich @brettfo
Merged PR 732978: Remove platform version when parsing NuGetFramework…
ef35c49 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 13, 2023
@JoeRobich @brettfo
Merged PR 732978: Remove platform version when parsing NuGetFramework…
b035ddd 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 16, 2023
@JoeRobich @brettfo
Merged PR 732978: Remove platform version when parsing NuGetFramework…
1f2715f 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 16, 2023
@JoeRobich @brettfo
Merged PR 732978: Remove platform version when parsing NuGetFramework…
8ed6b79 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Oct 16, 2023
@JoeRobich @brettfo
Merged PR 732978: Remove platform version when parsing NuGetFramework…
e5b4cd4 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
brettfo pushed a commit to brettfo/dependabot-core that referenced this pull request Nov 10, 2023
@JoeRobich @brettfo
Merged PR 732978: Remove platform version when parsing NuGetFramework…
d87e2bf 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
deivid-rodriguez pushed a commit to dependabot/dependabot-core that referenced this pull request Nov 13, 2023
@JoeRobich @deivid-rodriguez
Merged PR 732978: Remove platform version when parsing NuGetFramework…
e5ee75c 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
deivid-rodriguez pushed a commit to dependabot/dependabot-core that referenced this pull request Nov 14, 2023
@JoeRobich @deivid-rodriguez
Merged PR 732978: Remove platform version when parsing NuGetFramework…
57135b5 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
deivid-rodriguez pushed a commit to dependabot/dependabot-core that referenced this pull request Nov 14, 2023
@JoeRobich @deivid-rodriguez
Merged PR 732978: Remove platform version when parsing NuGetFramework…
4d09644 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
deivid-rodriguez pushed a commit to dependabot/dependabot-core that referenced this pull request Nov 14, 2023
@JoeRobich @deivid-rodriguez
Merged PR 732978: Remove platform version when parsing NuGetFramework…
6623bdf 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
deivid-rodriguez pushed a commit to dependabot/dependabot-core that referenced this pull request Nov 14, 2023
@JoeRobich @deivid-rodriguez
Merged PR 732978: Remove platform version when parsing NuGetFramework…
d139da9 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
deivid-rodriguez pushed a commit to dependabot/dependabot-core that referenced this pull request Nov 15, 2023
@JoeRobich @deivid-rodriguez
Merged PR 732978: Remove platform version when parsing NuGetFramework…
178a3e4 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
deivid-rodriguez pushed a commit to dependabot/dependabot-core that referenced this pull request Nov 15, 2023
@JoeRobich @deivid-rodriguez
Merged PR 732978: Remove platform version when parsing NuGetFramework…
f1a6635 
… from TFM

- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)

Related work items: #2092724
deivid-rodriguez pushed a commit to brettfo/dependabot-core that referenced this pull request Nov 15, 2023
@JoeRobich @deivid-rodriguez
Remove platform version when parsing NuGetFramework from TFM
d535af3 
- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)
deivid-rodriguez pushed a commit to brettfo/dependabot-core that referenced this pull request Nov 17, 2023
@JoeRobich @deivid-rodriguez
Remove platform version when parsing NuGetFramework from TFM
8f0a9d9 
- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)
deivid-rodriguez pushed a commit to brettfo/dependabot-core that referenced this pull request Nov 17, 2023
@JoeRobich @deivid-rodriguez
Remove platform version when parsing NuGetFramework from TFM
3772422 
- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)
deivid-rodriguez pushed a commit to brettfo/dependabot-core that referenced this pull request Nov 17, 2023
@JoeRobich @deivid-rodriguez
Remove platform version when parsing NuGetFramework from TFM
7fb69d1 
- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)
deivid-rodriguez pushed a commit to brettfo/dependabot-core that referenced this pull request Nov 17, 2023
@JoeRobich @deivid-rodriguez
Remove platform version when parsing NuGetFramework from TFM
838abcb 
- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)
deivid-rodriguez pushed a commit to brettfo/dependabot-core that referenced this pull request Nov 17, 2023
@JoeRobich @deivid-rodriguez
Remove platform version when parsing NuGetFramework from TFM
e593bd0 
- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)
deivid-rodriguez pushed a commit to brettfo/dependabot-core that referenced this pull request Nov 17, 2023
@JoeRobich @deivid-rodriguez
Remove platform version when parsing NuGetFramework from TFM
e28a41a 
- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)
deivid-rodriguez pushed a commit to brettfo/dependabot-core that referenced this pull request Nov 27, 2023
@JoeRobich @deivid-rodriguez
Remove platform version when parsing NuGetFramework from TFM
11901b0 
- PlatformVersion is not well supported by the FrameworkCompatibilityService
 (see NuGet/NuGetGallery#9364 for details)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agr agr agr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dannyjdev @agr