Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2FA] Update link msa/aad account page with legacy password account information. #9408

Merged
merged 4 commits into from Mar 10, 2023
Merged

[2FA] Update link msa/aad account page with legacy password account information. #9408

merged 4 commits into from Mar 10, 2023

Conversation

dannyjdev
Copy link
Contributor

@dannyjdev dannyjdev commented Mar 2, 2023 •
edited

Changes

  • Updated wording of the "Link Microsoft Account" page to include Legacy Account information.
  • Legacy account page: This page will show when users have password account and are not part of the exception list.
  • Link Microsoft account page: After a user with a legacy account issue sends a SR to us, we will verify the request and ownership. Once we approve it using our processes, the user will see this page and will be able to link their MSA if they know their password, otherwise they will be able to use the Forgot your password? link.

Screenshot

Legacy account page

Legacy Account

Link MSA account page

Linking account

Addresses: https://github.com/NuGet/Engineering/issues/4617

@dannyjdev dannyjdev requested a review from a team as a code owner March 2, 2023 03:28
joelverhagen
joelverhagen requested changes Mar 2, 2023
View reviewed changes
Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments on interaction with the allow-list.

@dannyjdev dannyjdev merged commit 506336e into dev Mar 10, 2023
@dannyjdev dannyjdev deleted the dev-dj-2fapasswordpagefix branch March 10, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyndaidaii lyndaidaii lyndaidaii left review comments

@joelverhagen joelverhagen joelverhagen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dannyjdev @joelverhagen @lyndaidaii