Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y] Search page a11y fixes for tags and framework filter buttons #9429

Merged
merged 4 commits into from
Mar 16, 2023
Merged

[A11y] Search page a11y fixes for tags and framework filter buttons #9429

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1164782
tags break line: attempt 1
advay26 Mar 13, 2023
c55624a
fixed tags on next line
advay26 Mar 14, 2023
384d9ef
removed dev configs
advay26 Mar 14, 2023
7c03539
smaller screens didn't need fixing in the first place
advay26 Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Bootstrap/dist/css/bootstrap-theme.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions src/Bootstrap/less/theme/base.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,6 +357,10 @@ img.reserved-indicator-icon {
outline-offset: 0;
}
}

.package-tags {
display: block;
}
}

@media (min-width: @screen-sm-min) {
Expand All @@ -369,6 +373,7 @@ img.reserved-indicator-icon {
}

li.package-tags {
display: block;
advay26 marked this conversation as resolved.
Show resolved Hide resolved
overflow-y: visible;
}
}
Expand Down
4 changes: 4 additions & 0 deletions src/NuGetGallery/Scripts/gallery/page-list-packages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,14 @@ $(function() {
expandButton.classList.toggle('ms-Icon--ChevronUp');

if (this.classList.contains('active')) {
this.setAttribute("aria-expanded", "true");

dataTab.style.display = 'block';
dataTab.style.maxHeight = dataTab.scrollHeight + "px";
}
else {
this.setAttribute("aria-expanded", "false");

dataTab.style.display = 'none';
dataTab.style.maxHeight = 0;
}
Expand Down
3 changes: 2 additions & 1 deletion src/NuGetGallery/Views/Shared/ListPackages.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
<div class="frameworkgoup">
<input type="checkbox" id="@(frameworkShortName)" class="framework">
<label for="@(frameworkShortName)">@(frameworkDisplayName)</label>
<button type="button" class="collapsible" tab="@(frameworkShortName)" tabindex="0" aria-label="shows and hides TFM filters">
<button type="button" class="collapsible" tab="@(frameworkShortName)" tabindex="0"
aria-label="shows and hides TFM filters for @(frameworkDisplayName)" aria-expanded="false" aria-controls="@(frameworkShortName)tab">
<i class="ms-Icon ms-Icon--ChevronDown" id="@(frameworkShortName)button"></i>
</button>
<div class="tfmTab" id="@(frameworkShortName)tab">
Expand Down
5 changes: 2 additions & 3 deletions src/NuGetGallery/Views/Shared/_ListPackage.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
href="@Url.Package(Model.Id, Model.UseVersion ? Model.Version : null).TrimEnd('/')"
@if (itemIndex.HasValue)
{
@:data-track="@eventName" data-track-value="@itemIndex"
@:data-package-id="@Model.Id" data-package-version="@Model.Version" data-use-version="@Model.UseVersion"
@:data-track="@eventName" data-track-value="@itemIndex"
@:data-package-id="@Model.Id" data-package-version="@Model.Version" data-use-version="@Model.UseVersion"
}
>@Html.BreakWord(Model.Id)</a>

Expand Down Expand Up @@ -93,7 +93,6 @@
</li>
@if (Model.Tags.AnySafe())
{
<br/>
<li class="package-tags">
<span class="icon-text">
<i class="ms-Icon ms-Icon--Tag" aria-hidden="true"></i>
Expand Down