Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A11y] Fix Framework filter tooltip's confusing double behavior #9454

Merged
merged 2 commits into from Apr 6, 2023

Conversation

advay26
Copy link
Contributor

@advay26 advay26 commented Apr 5, 2023

Addresses #9414

The tooltip next to the Frameworks filters served both as a popover (showed some info when you hovered) and also as a link to our Target Frameworks docs, and the same tooltip icon produced two separate tab stops that told users this icon served different purposes. We needed to either separate these into 2 separate controls, or get rid of one of them. I got rid of the popover, but using the 'title' attribute in the link allows me to serve up the same information when a user hovers or tabs to the link icon. I think this should fix the a11y issue while still providing the users the same level of context.

I also changed the link to point to our nuget.org filtering and sorting docs, rather than this page that covers Target Frameworks in general. The search docs are more relevant in this case, and they contain a link to the Target Frameworks docs anyway.

Earlier, we would see this popover when we hovered on the icon,
image

Now, when you hover, the same information will pop up, but it will look different to these popovers. I wasn't able to get a screenshot because the info disappeared when I tried, but it looks like what you'll see when you hover over any of the other links on the search page like owners or tags. There is no other UI change.
image

@advay26 advay26 requested a review from a team as a code owner April 5, 2023 22:20
@advay26 advay26 requested a review from ryuyu April 5, 2023 22:21
@advay26 advay26 merged commit 2a9a353 into dev Apr 6, 2023
1 check passed
@advay26 advay26 deleted the dev-advay26-a11y branch April 6, 2023 18:37
@advay26 advay26 mentioned this pull request Apr 8, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants