Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip/popover placement update #9457

Merged
merged 8 commits into from
Apr 10, 2023
Merged

Tooltip/popover placement update #9457

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c499d36
Make popovers to switch to appearing on the left of the relevant elem…
agr Apr 4, 2023
42d4237
More flexible setup.
agr Apr 5, 2023
133397f
Using body as a popover container.
agr Apr 5, 2023
2ef596c
Body container for popovers.
agr Apr 5, 2023
84edea8
Limiting popover update only to the reported case.
agr Apr 5, 2023
adf08ec
Custom placement logic.
agr Apr 5, 2023
8a608a1
Constants for magic numbers.
agr Apr 6, 2023
4588ce1
let -> const.
agr Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 30 additions & 3 deletions src/NuGetGallery/Scripts/gallery/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,13 +461,40 @@
};

nuget.setPopovers = function () {
var popoverElement = $(this);
var popoverElementDom = this;
setPopoversInternal(this, rightWithVerticalFallback);
}

function rightWithVerticalFallback(popoverElement, ownerElement) {
// Both numbers below are in CSS pixels.
const MinSpaceOnRight = 150;
const MinSpaceOnTop = 100;

const ownerBoundingBox = ownerElement.getBoundingClientRect();
const spaceOnRight = window.innerWidth - ownerBoundingBox.right;
if (spaceOnRight > MinSpaceOnRight) {
return 'right';
}
const spaceOnTop = ownerBoundingBox.top;
if (spaceOnTop > MinSpaceOnTop) {
return 'top';
}

return 'bottom';
agr marked this conversation as resolved.
Show resolved Hide resolved
}

function setPopoversInternal(element, placement) {
var popoverElement = $(element);
var popoverElementDom = element;
var originalLabel = popoverElementDom.ariaLabel;
var popoverHideTimeMS = 2000;
var popoverFadeTimeMS = 200;

popoverElement.popover({ trigger: 'hover' });
var popoverOptions = { trigger: 'hover', container: 'body' };
if (placement) {
popoverOptions.placement = placement;
}

popoverElement.popover(popoverOptions);
popoverElement.click(popoverShowAndHide);
popoverElement.focus(popoverShowAndHide);
popoverElement.keyup(function (event) {
Expand Down