Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fixes for Dark theme #9949

Merged

Conversation

martinrrm
Copy link

@martinrrm martinrrm commented May 18, 2024

This PR fixes some UI errors found while testing in dev deployment.

This PR also includes a lot of changes to "hard-coded" colors to CSS variables

Spec: https://github.com/NuGet/Engineering/pull/5209
Main Issue: #8773

Statistics page

image

README

image

Vulnerable/Deprecated tags

image

@martinrrm martinrrm requested a review from a team as a code owner May 18, 2024 01:25
@martinrrm martinrrm force-pushed the dev-martinrrm-feature-new-theme branch from 92afa45 to 3874a9e Compare May 22, 2024 18:01
@martinrrm martinrrm force-pushed the dev-martinrrm-dark-theme-fixes-2 branch from c105c1c to ff754ef Compare May 22, 2024 18:06
@@ -0,0 +1,5 @@
.page-contact{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a space here.

@loic-sharma
Copy link
Contributor

The new copy button is so beautiful for multi-line installation instructions!!! 😂

Screenshot 2024-05-24 at 7 32 28 AM

@martinrrm martinrrm merged commit 86bb688 into dev-martinrrm-feature-new-theme May 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants