Add client secret authentication for Service Bus #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
loic-sharma
reviewed
Feb 11, 2021
| @@ -16,6 +18,25 @@ public TopicClientWrapper(string connectionString, string path) | |||
| _client = TopicClient.CreateFromConnectionString(connectionString, path); | |||
| } | |||
|
|
|||
| public TopicClientWrapper(String clientId, string clientSecret, string tenantId, string serviceBusUrl, string path) | |||
There was a problem hiding this comment.
Please make sure to use the string keyword:
Suggested change
| public TopicClientWrapper(String clientId, string clientSecret, string tenantId, string serviceBusUrl, string path) | |
| public TopicClientWrapper(string clientId, string clientSecret, string tenantId, string serviceBusUrl, string path) |
For more information why, see: https://blog.paranoidcoding.com/2019/04/08/string-vs-String-is-not-about-style.html
loic-sharma
reviewed
Feb 11, 2021
| @@ -12,11 +12,12 @@ | |||
| <PackageReference Include="Microsoft.Extensions.Logging"> | |||
| <Version>2.2.0</Version> | |||
| </PackageReference> | |||
| <PackageReference Include="Microsoft.Identity.Client" Version="4.25.0" /> | |||
There was a problem hiding this comment.
Please follow the style of the other PackageReferences in this file. (To be honest, I personally prefer your style but we should stay consistent.)
Suggested change
| <PackageReference Include="Microsoft.Identity.Client" Version="4.25.0" /> | |
| <PackageReference Include="Microsoft.Identity.Client"> | |
| <Version>4.25.0</Version> | |
| </PackageReference> |
loic-sharma
changed the title
nikhgup
force-pushed
the
serviceBusUpdate
branch
from
2eebeb1
to
ac4ef7d
Compare
loic-sharma
requested review from
agr,
dannyjdev,
drewgillies,
joelverhagen,
lyndaidaii,
ryuyu,
skofman1 and
zhhyu
This was referenced Feb 12, 2021
loic-sharma
reviewed
Feb 13, 2021
loic-sharma
approved these changes
Feb 13, 2021
Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
| <PackageReference Include="Newtonsoft.Json"> | ||
| <Version>10.0.3</Version> | ||
| </PackageReference> | ||
| <PackageReference Include="WindowsAzure.ServiceBus"> | ||
| <Version>4.1.3</Version> | ||
| <Version>6.0.3</Version> |
There was a problem hiding this comment.
This is a little spooky. Have we tested all of our Service Bus jobs?
There was a problem hiding this comment.
Agreed. I tested 1 receiver scenario (Orchestrator) and two sender scenarios (Gallery and Orchestrator). Our jobs all use the same underlying framework to send/receive Service Bus messages, so I think this should cover all our jobs.
| @@ -16,6 +18,25 @@ public TopicClientWrapper(string connectionString, string path) | |||
| _client = TopicClient.CreateFromConnectionString(connectionString, path); | |||
| } | |||
|
|
|||
| public TopicClientWrapper(string clientId, string clientSecret, string tenantId, string serviceBusUrl, string path) | |||
| { | |||
| AzureActiveDirectoryTokenProvider.AuthenticationCallback authCallback = async (audience, authority, state) => | |||
joelverhagen
approved these changes
Feb 16, 2021
lyndaidaii
approved these changes
Feb 17, 2021
loic-sharma
added a commit
to NuGet/NuGet.Jobs
that referenced
this pull request
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for client secret based authentication
upgrading servicebus library
adding Microsoft.Identity.client nuet package
Tracked by: https://github.com/NuGet/Engineering/issues/3650