Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for .NET Framework 4.8.1 & .NET 7 #1556

Merged
merged 13 commits into from
Jul 21, 2023
Merged

Support for .NET Framework 4.8.1 & .NET 7 #1556

merged 13 commits into from
Jul 21, 2023

Conversation

Wagnerp
Copy link
Contributor

@Wagnerp Wagnerp commented Oct 30, 2022

@clairernovotny
Copy link
Member

Looks good overall except for adding the 7.0 to windows as per the comment above. not sure why?

clairernovotny
clairernovotny requested changes Dec 14, 2022
View reviewed changes
Copy link
Member

@clairernovotny clairernovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change windows7.0 back to windows

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Dec 15, 2022

Please change windows7.0 back to windows

@clairernovotny Reinstated for .NET 5, but you can't do the same with >= .NET 6, otherwise it'll fail to save the package. See #1566 for details.

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Jan 7, 2023

Update, removed -windows7.0 -> -windows

@Wagnerp
Copy link
Contributor Author

Wagnerp commented Feb 25, 2023

Added .NET 8 to the list

@clairernovotny clairernovotny merged commit a005afd into NuGetPackageExplorer:main Jul 21, 2023
3 of 10 checks passed
@Wagnerp Wagnerp deleted the net481net7support branch July 22, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clairernovotny clairernovotny Awaiting requested review from clairernovotny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Wagnerp @clairernovotny