awesomewm: Setting to specify the prefix of the battery current and full charge path #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt and full charge path
|
Great PR, though the behavior should probably match the behavior in C. I had kind of assumed it did, I guess I was wrong >_> |
|
I agree completely that making it not require a setting is better. This commit matches more or less directly the way it is being done in the C code. Should I try to reduce code duplication while still having the same behavior or do you prefer it to be similar to the way it is done in C? |
|
Feel free to write it not idiomatically, Lua is certainly not C |
|
👍 |
NuckChorris
added a commit
that referenced
this pull request
Jan 28, 2015
awesomewm: Setting to specify the prefix of the battery current and full charge path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case, the battery charge paths where named "charge_now" and "charge_full" rather than "energy_now" and "energy_full". This change enables the user to set their own prefix if it is needed.