fix: always include the pubkey in the inner bytes #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inner bytes payload contained in a
SignedPacket
currently is different depending on how theSignedPacket
was constructed. So theAsRef<[u8]>
would returns a byte slice with the 32 byte pubkey at the beginning if the packet was created withSignedPacket::from_packet()
and without the 32 byte pubkey if created withSignedPacket::from_relay_response()
.This PR fixes this and also exposes
as_bytes
/from_bytes
methods which are useful for persisting the full signed packet to a database or cache.