Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional sub_collect to _detectImports #2383

Open
wants to merge 62 commits into
base: develop
Choose a base branch
from

Conversation

byehack
Copy link
Contributor

@byehack byehack commented Aug 12, 2023

What does this PR do?

fixes #2384

This will avoid to be multiple path search for interpreter.
for startup packages we should include all submodules not that parts only needed for interpreter (ref: pyinstaller)

Why was it initiated? Any relevant Issues?

No, I didn't open issue.

PR Checklist

  • Correct base branch selected? Should be develop branch.
  • Enabled commit hook or executed ./bin/autoformat-nuitka-source.
  • All tests still pass. Check the Developer Manual about Running the Tests.
    There are GitHub Actions tests that cover the most important
    things however, and you are welcome to rely on those, but they might not
    cover enough.
  • Ideally new features or fixed regressions ought to be covered via new tests.
  • Ideally new or changed features have documentation updates.

kayhayen and others added 30 commits July 23, 2023 19:10
* We still get file too short for constant.bin, lets see what it should be.
* This should e.g. also make scons build failures generate a
  report.
* These are extremely common and normal apparently, do not bother users
  with it.
* New black removes a few leading new lines in blocks, so many
  files changed in that way.

* The "pygments" has a vulnerability, but updating that and the
  restructured text checking stuff did not actually matter at
  all.

* Bumped needed version for development to 3.8, since black does
  not do 3.7 anymore, and it's old enough.
* No changes needed for this.
* This adds another function to change.
* This in turn used "numpy" and could become large.
* Just like Debian, they pick their own folder name it seems.
@kayhayen
Copy link
Member

Can you follow this to rebase: https://nuitka.net/doc/developer-manual.html#nuitka-git-github-workflow

I want to take a look, what this changes, and what to take from it, and why.

@kayhayen kayhayen self-assigned this Nov 27, 2023
Copy link
Member

@kayhayen kayhayen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase to be able to look at it cleanly and compare with what current code does, to see what improvements it gives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect submodules without follow imports in them.
4 participants