Added optional sub_collect to _detectImports
#2383
Open
+5,091
−3,500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We still get file too short for constant.bin, lets see what it should be.
* This should e.g. also make scons build failures generate a report.
* These are extremely common and normal apparently, do not bother users with it.
* New black removes a few leading new lines in blocks, so many files changed in that way. * The "pygments" has a vulnerability, but updating that and the restructured text checking stuff did not actually matter at all. * Bumped needed version for development to 3.8, since black does not do 3.7 anymore, and it's old enough.
* No changes needed for this.
* This adds another function to change.
* This in turn used "numpy" and could become large.
* Just like Debian, they pick their own folder name it seems.
kayhayen
force-pushed
the
develop
branch
6 times, most recently
from
8e21b6a
to
e17eb82
Compare
kayhayen
force-pushed
the
develop
branch
5 times, most recently
from
a1bfc9c
to
b763365
Compare
|
Can you follow this to rebase: https://nuitka.net/doc/developer-manual.html#nuitka-git-github-workflow I want to take a look, what this changes, and what to take from it, and why. |
kayhayen
requested changes
Nov 27, 2023
kayhayen
force-pushed
the
develop
branch
2 times, most recently
from
4ef5357
to
86bde4b
Compare
kayhayen
force-pushed
the
develop
branch
2 times, most recently
from
5907fc4
to
6a1842b
Compare
kayhayen
force-pushed
the
develop
branch
4 times, most recently
from
98fe7dc
to
7ce9309
Compare
kayhayen
force-pushed
the
develop
branch
3 times, most recently
from
30eb085
to
f3b9d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fixes #2384
This will avoid to be multiple path search for interpreter.
for startup packages we should include all submodules not that parts only needed for interpreter (ref: pyinstaller)
Why was it initiated? Any relevant Issues?
No, I didn't open issue.
PR Checklist
developbranch../bin/autoformat-nuitka-source.Running the Tests.There are GitHub Actions tests that cover the most important
things however, and you are welcome to rely on those, but they might not
cover enough.