-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement getting binary path on OpenBSD #2869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
1297147
to
7e8cd1c
Compare
So, I am able to force push into your repository there. I rebased to develop, and commented out with |
Make sure do |
@kayhayen Is there a sample program I can compile to verify the output against what it's supposed to look like? |
tests/standalone/CtypesUsing.py |
It doesn't crash at least, is it supposed to do something? |
Oh yes, it is only tested on Windows and Linux really, use tests/standalone/LxmlUsing.py with lxml installed of course then. Not crashing is very good though. :) |
Well I mean is there something that actually tests this binary-name-getting functionality? |
Standalone does have to use it at program launch I think, cannot work without it, I believe. But you can always just |
Did you have a chance to try printing file ? |
Looks like it works:
|
Ok, I will give a final brush up then and merge it to factory. i will keep you posted, when you should try it. |
This commit adds a mostly untested function to get the path to the running binary on OpenBSD. https://stackoverflow.com/questions/31494901/how-to-get-the-executable-path-on-openbsd
209af5d
to
ca389a0
Compare
Can you try the current factory branch: You can try it out by going here: https://nuitka.net/doc/factory.html |
I'm currently getting this:
|
Ok, please retry, my bad. |
@kayhayen It's working for me :) |
Great, adding OpenBSD to the list of supported OSes. :) |
This will be in the 2.3 release shortly |
Can you check if onefile works for you if you extend the list, I wouldn't know why not. |
What does this PR do?
This commit adds a mostly untested function to get the path to the running binary on OpenBSD.
https://stackoverflow.com/questions/31494901/how-to-get-the-executable-path-on-openbsd
Why was it initiated? Any relevant Issues?
I initiated the PR upon request from here: #662 (comment)
I'm sorry I can't really help out more, I just did this as a quick hack to get my own thing working so I'm sure it needs to be revised before merging.
PR Checklist
develop
branch../bin/autoformat-nuitka-source
.Running the Tests
. There are GitHubActions tests that cover the most important things however, and you are welcome to rely on those,
but they might not cover enough.