CI: make sure the target toolchain is available #321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cross-compilation builds, the target toolchain needs to be installed (you
can't count on it being present in a GH build environment).
Making this change (adding the
target: ${{ matrix.target }}
line to theactions-rs/toolchain@v1
action), make my PR #320 build properly for the iOScross-compilation target *). Without it, you may get errors like:
With the
target
line rustup makes sure to add any missing toolchains; e.g. the iOS Setup Rust toolchain step now includes:If you were lucky and got a build machine that already had the toolchain installed, the build would pass, I think.
Note: I omitted a changelog entry as this is purely a CI fix.
Checklist
CHANGELOG.md
.cargo clippy
andcargo fmt
. The CI will fail otherwise anyway.*) The
aarch64-apple-ios
build was cancelled because of an unrelated issue with a pre-existingclippy
warning, but the build got well past the point where otherwise it'd have failed.