Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Update Nukkit to support client verstion 1.1.0 #1743

Closed
dcmwai opened this issue Jun 2, 2017 · 80 comments
Closed

Update Nukkit to support client verstion 1.1.0 #1743

dcmwai opened this issue Jun 2, 2017 · 80 comments

Comments

@dcmwai
Copy link

dcmwai commented Jun 2, 2017

Unable to join server when client version is 1.10 (Win 10 PE/iOS


Edit by @Snake1999:

We need your help for testing our software for client 1.1.0! Compile code on https://github.com/yescallop/Nukkit/tree/1.1.0 and try it out~ After tested OK, our main branch will be updated to 1.1.0.

We are now working 1.1.0 on: https://github.com/yescallop/Nukkit/tree/1.1.0
Any contributions please go to the site above. We welcome every bit of your work.

Go on nukkiting out our code :)


As our new branch is bleeding - still under construction and maybe buggy or unfit for production use, no jar file are available for 1.1.0 yet unless you do the compile work by yourself. @PetteriM1


@yungtechboy1
Copy link
Contributor

👍

@imjack
Copy link
Contributor

imjack commented Jun 2, 2017

That's because it's not updated to the latest version

@MasterlazorX
Copy link

MasterlazorX commented Jun 2, 2017

It's not updated to to 1.1 yet, so it's not considered an issue.

@kvetinac97
Copy link
Contributor

Anyways, somebody should update it. @yescallop ?

@MasterlazorX
Copy link

MasterlazorX commented Jun 2, 2017

And i'm sure there's a BUNCH of protocol changes to mcpe 1.1.

@Creeperface01
Copy link
Contributor

or @kvetinac97 ?

@jrodr10
Copy link

jrodr10 commented Jun 2, 2017

We're gonna need a binary rewrite & nbt rewrite & protocol change to 113 ._.

@DaMatrix
Copy link

DaMatrix commented Jun 2, 2017

...and this is where nukkit dies. with no active devs and a massive update like this, we ain't gonna be getting an update at this rate. :/

@DaMatrix
Copy link

DaMatrix commented Jun 3, 2017

i know more than a bit about what's required, i'm making a general commentary that the original devs are pretty much dead and nukkit doesn't get much any more other than occastional version bumps and a PR every once in a while.

@boybook
Copy link
Contributor

boybook commented Jun 3, 2017

I'm trying to write about it but lots of problems.

@ScraM-Team
Copy link
Contributor

Let us know how we can help with 1.1.0. We're big Nukkit fans here on the ScraM team.

@Creeperface01
Copy link
Contributor

@yescallop is quite experienced so maybe he could help us with update

@Snake1999
Copy link
Member

Doing coding on 1.10. Dont worry.

@imjack
Copy link
Contributor

imjack commented Jun 3, 2017

Push what you've got maybe we can help.

@yescallop
Copy link
Contributor

I've been working on it
https://github.com/yescallop/Nukkit/tree/1.1.0
Now players are able to join the server, but there are still some bugs. Trying to fix them.

@Creeperface01
Copy link
Contributor

@yescallop idk why but Im getting stuck at "syncing pack with server" screen

@imjack
Copy link
Contributor

imjack commented Jun 3, 2017

@yescallop seems when walking the player thinks it's sneaking hence the shaking screen.
Another bug is with bubbles - maybe the flags have changed?

@ScraM-Team
Copy link
Contributor

@yescallop , I will try it now with ScraM for MCPE.

@ScraM-Team
Copy link
Contributor

Just got this, will try to fix:

Nukkit-1.1.0/src/main/java/cn/nukkit/level/sound/TNTPrimeSound.java:[16,36] cannot find symbol
[ERROR] symbol: variable EVENT_SOUND_TNT
[ERROR] location: class cn.nukkit.network.protocol.LevelEventPacket

@antoinnneee
Copy link

antoinnneee commented Jun 3, 2017

I fix this error, you just need to add :
public static final int EVENT_SOUND_TNT = 1005; // (random value)
in file : /src/main/java/cn/nukkit/network/protocol/LevelEventPacket.java

@kvetinac97
Copy link
Contributor

@yescallop Very good job! Altough some Inventory packets and metadata had to change (sneaking shaking + bubbles, inventory not working well), it is well working.

@ScraM-Team
Copy link
Contributor

@yescallop , it is looking great! I can log in with 1.1.0. The main issue I see is the "sneak shake". The sneak button on the client is toggling on and off every half second or so, causing the screen to shake slightly up and down. (reported by others above already).

@antoinnneee , thanks for the TNT sound tip. I switched it to a different, valid sound (SPLASH) so that I would get some sound, even though it's not the right one.

@Goodstuff4UonYT
Copy link

Goodstuff4UonYT commented Jun 5, 2017

@yescallop If I spawn some flaoting text particle, my skin will also spawn at the floating text particle.

@DaMatrix
Copy link

DaMatrix commented Jun 5, 2017

I can't join with the current latest commit, I get stuck on "Locating Server".

EDIT: never mind, it was a plugin

@kvetinac97
Copy link
Contributor

Now, the main things that remain to fix is touchEvent (BlockPickRequestPacket?) and inventory (add the missing slot)

@Goodstuff4UonYT
Copy link

@yescallop Now all floating text particle are invisible or don't spawn.

@boybook
Copy link
Contributor

boybook commented Jun 5, 2017

@Goodstuff4UonYT Fixed in yescallop@e97811b

@Snake1999 Snake1999 changed the title ver 1.10 can't join nukkit Update Nukkit to support client verstion 1.10 Jun 5, 2017
@karpovichv
Copy link
Member

So how it goes?

@Snake1999
Copy link
Member

Not yet. Ramping down bugs :)

@Goodstuff4UonYT
Copy link

@boybook you can't cancel the InventoryClickEvent? Is there any other possibility to avoid that the win 10 player can pick a item and drag it around?

@boybook
Copy link
Contributor

boybook commented Jun 12, 2017

Sorry, I have not studied this method, so now temporarily for the TODO state.

@MasterlazorX
Copy link

MasterlazorX commented Jun 13, 2017

@Snake1999 Block breaking time issue still exists. I used my hand and all kinds of tools to break blocks. Tested on local.

@Snake1999
Copy link
Member

@MasterlazorX The time calculating is CORRECT (matches what minecraft wiki says), but the client seems strange receiving "correct" information. Having further checks in it.

@boybook
Copy link
Contributor

boybook commented Jun 16, 2017

I did a test for this, as long as do Thread.sleep(pause) a short time after sending StartGamePacket, the game will not crash again.
Please personally test to determine the correctness of this discovery.

//After StartGamePacket sent
Thread.sleep(50);

@Alexey336
Copy link

Left click doesen't work.
image
image

@Creeperface01
Copy link
Contributor

is it PE or windows 10?

@Alexey336
Copy link

Windows 10, but same problem for pe too

@Creeperface01
Copy link
Contributor

Its probably start break

@Alexey336
Copy link

Block's doesn't appear correct after changing with plugins like worldedit. It's normal only after rejoin.

image

@chadsnet
Copy link

That last 1.1.0 .jar work great for getting my mobile up on the server, but still can't get the Windows 10 client to join. What drives me crazy is how am I able to join random servers out there that are older versions. Hell I joined one that was 1.0.0. (this is my first day with your software and minecraft in general)

@nasiridrishi
Copy link

hey, you can join server by going to a pocketmine server and directly get transfferd to the server!!

@EnderKenji
Copy link

EnderKenji commented Jun 24, 2017

The chunk bug still a thing, just not happens too often,

🐞Bugs I knw:

  • When raining, thunder won't stop.
  • When I do /time stop , the time wont stop.
  • When I place colored bed, it turned into white, after i relog, it changed color. (known bug)

Using latest build. (1.1 push request)

@AntiEngineer
Copy link

image
Hello! I'm having a bug that honestly stresses me out:

  • OPs can't use any commands.
  • Chunks not loading AND screen is shaking
  • Client crashes constantly
  • No movement at all, stuck shaking in a point.

I'm using yescallop/Nukkit@46a28a0 at the moment, I already tested : 1033c04 also and the same issues still happen.

The server is running Ubuntu at the moment, already tested with CentOS.

Client runs Windows 10, no way to test in PE because I don't have any PE device.

Thanks :D

@nasiridrishi
Copy link

wonder I m using it with no problem!!!

@AntiEngineer
Copy link

Found a way to bypass this error, when there's no worlds and the generator is set to make DEFAULT world, it causes this, when it's to FLAT, it gets fixed :D

@averagesecurityguy
Copy link

I've been using the 1.1.0 version from @yescallop for the last day. I can't make a furnace, which is a known issue and blocks don't want to break the first time. Other than that things seem to be working well. Thanks for the software, my kids really appreciate having their own server.

@Snake1999
Copy link
Member

As 1.1 now merged to master, all problems and bugs, please create issue in nukkit/nukkit.

@AntiEngineer
Copy link

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests