Add disable_local_debug to qunit, as we have a bug we need to fix, bu…

…t it was likely pre-existing Add disable_local_debug to bin/run-tests
NullVoxPopuli · Nov 14, 2023 · 1856b8c · 1856b8c
1 parent 0092ad7
commit 1856b8c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/bin/run-tests.js b/bin/run-tests.js
@@ -39,7 +39,7 @@ function run(queryString) {
     queryString = `${queryString}&debugrendertree`;
   }
 
-  let url = 'http://localhost:' + PORT + '/tests/?' + queryString;
+  let url = 'http://localhost:' + PORT + '/tests/?disable_local_debug&' + queryString;
   return runInBrowser(url, 3);
 }
 

diff --git a/testem.browserstack.js b/testem.browserstack.js
@@ -58,7 +58,7 @@ const BrowserStackLaunchers = {
 };
 
 module.exports = {
-  test_page: 'dist/tests/index.html?hidepassed&hideskipped&timeout=60000',
+  test_page: 'dist/tests/index.html?hidepassed&hideskipped&timeout=60000&disable_local_debug',
   timeout: 1200,
   reporter: FailureOnlyPerBrowserReporter,
   browser_start_timeout: 2000,

diff --git a/testem.ci-browsers.js b/testem.ci-browsers.js
@@ -1,7 +1,7 @@
 const FailureOnlyReporter = require('testem-failure-only-reporter');
 
 module.exports = {
-  test_page: 'tests/index.html?hidepassed&hideskipped&timeout=60000',
+  test_page: 'tests/index.html?hidepassed&hideskipped&timeout=60000&disable_local_debug',
   browser_disconnect_timeout: 120,
   timeout: 540,
   parallel: 1,

diff --git a/testem.js b/testem.js
@@ -1,5 +1,11 @@
 module.exports = {
-  test_page: 'tests/index.html?hidepassed',
+  /**
+   * disable_local_debug was added as a supported dev-time glimmer-vm feature and lives here:
+   *   https://github.com/glimmerjs/glimmer-vm/blob/master/packages/%40glimmer/local-debug-flags/index.ts
+   *
+   * It was introduced in: https://github.com/glimmerjs/glimmer-vm/pull/1427
+   */
+  test_page: 'tests/index.html?hidepassed&disable_local_debug',
   timeout: 540,
   parallel: 4,
   disable_watching: true,