Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: transfer settings to another device #434

Closed
wants to merge 3 commits into from
Closed

Feature: transfer settings to another device #434

wants to merge 3 commits into from

Conversation

NullVoxPopuli
Copy link
Owner

Supersedes: #110

@NullVoxPopuli NullVoxPopuli mentioned this pull request Jan 15, 2020
Closed
@sukima
Copy link

sukima commented Jan 15, 2020

The use of xstate looks good and i like where this is going. I do have Some comments that came up.

The xstate definition in this pr feels disjointed to me. I had trouble following its flow. Maybe if it were plugged into the xstate visualizer?

The switch/case seems odd in this case. First a simple object lookup would work but also xstate provides for side effect events via services. Then the logic would be declarative along with the xstate definition itself.

Let’s catch up via chat when i am not looking at this on my mobile phone.

@NullVoxPopuli
Copy link
Owner Author

How do I even github: https://xstate.js.org/viz/?gist=23cf0c840cf6403ae6a3f37e9095735f

@sonarcloud
Copy link

sonarcloud bot commented Jan 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@NullVoxPopuli
Copy link
Owner Author

Superseded by: #733

@NullVoxPopuli NullVoxPopuli mentioned this pull request Apr 14, 2020
Merged
@NullVoxPopuli NullVoxPopuli deleted the transfer-profile-to-device branch December 12, 2020 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement General Security High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NullVoxPopuli @sukima