Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use content-tag so that we can work on Safari / iOS #1162

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

@stackblitz
Copy link

stackblitz bot commented Jul 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2023

⚠️ No Changeset found

Latest commit: 73ae37c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@patricklx
Copy link

I've made a babel version of content-tag if that helps you.
https://github.com/patricklx/ember-template-tag

@NullVoxPopuli
Copy link
Owner Author

NullVoxPopuli commented Jul 30, 2023

3.9KB is certainly more attractive than > 741Kb

Though, I already have all of babel in the repl (which is approaching 5 MB). I wonder if there there is any benefit to moving all of my infra to SWC for parsing / compiling via WASM instead of babel.

Right now, 3.9KB is fantastic. (Keeps me under 5 MB in transpilation assets).

I need to look in to switching to SWC though -- maybe it's doable -- would need to figure out if they support legacy decorators -- or wait until @ef4's work with supporting both legacy decorators and spec-decorators... and then just have less transpilation in general.

@NullVoxPopuli
Copy link
Owner Author

@patricklx it was not so easy 🙃 I opened a couple issues on your repo, and opened this PR for ember-template-tag: #1168

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review November 6, 2023 23:51
@NullVoxPopuli NullVoxPopuli merged commit f643b12 into main Nov 7, 2023
8 checks passed
@NullVoxPopuli NullVoxPopuli deleted the use-content-tag branch November 7, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants