Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call inner writer's poll_flush instead of poll_close #91

Merged
merged 1 commit into from May 15, 2020
Merged

Call inner writer's poll_flush instead of poll_close #91

merged 1 commit into from May 15, 2020

Conversation

gnosek
Copy link
Contributor

@gnosek gnosek commented May 15, 2020

No description provided.

@gnosek
Copy link
Contributor Author

gnosek commented May 15, 2020

Looks like a copy/paste error and with this patch my tests (several layers up) pass, but I'm curious to know if this is by design.

cc @Nemo157

@Nemo157
Copy link
Member

Nemo157 commented May 15, 2020

Definitely looks like a copy-paste error to me. Looks like I need to improve the writer used in the tests to actually close itself when poll_close is called so that it can detect this.

@Nemo157
Copy link
Member

Nemo157 commented May 15, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented May 15, 2020

Build succeeded:

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 0852f42 into Nullus157:master May 15, 2020
@gnosek
Copy link
Contributor Author

gnosek commented May 15, 2020

Thanks!

@Nemo157 Nemo157 mentioned this pull request May 15, 2020
Merged
bors bot added a commit that referenced this pull request May 15, 2020
@bors @Nemo157
Merge #92
e8938d9 
92: Test and fix flushing r=Nemo157 a=Nemo157

Tests and finishes fixing issues from #91 

Co-authored-by: Wim Looman <git@nemo157.com>
@Nemo157
Copy link
Member

Nemo157 commented May 15, 2020

I fixed the decoder as well in #92 and just published 0.3.4 with the fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gnosek @Nemo157