Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing nc_data_cluster_wl integration #146

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Conversation

caioolivv
Copy link
Member

  • Optimized nc_galaxy_sd_position_integ by removing gsl_gamma_ran
  • Optimize nc_galaxy_sd_shape_integ with nc_wl_surface_mass_density_reduced_shear_optzs (this seemingly makes the integration slower?)

@caioolivv caioolivv requested a review from vitenti March 4, 2024 15:16
@caioolivv caioolivv self-assigned this Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 63.60%. Comparing base (2e3f954) to head (9b82dc7).
Report is 2 commits behind head on wl_rebuild.

❗ Current head 9b82dc7 differs from pull request most recent head f3b0e1c. Consider uploading reports for the commit f3b0e1c to get more accurate results

Files Patch % Lines
numcosmo/galaxy/nc_galaxy_sd_shape.c 71.42% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           wl_rebuild     #146      +/-   ##
==============================================
+ Coverage       62.39%   63.60%   +1.20%     
==============================================
  Files             489      490       +1     
  Lines           89723    89772      +49     
==============================================
+ Hits            55985    57099    +1114     
+ Misses          33738    32673    -1065     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caioolivv caioolivv merged commit 937541a into wl_rebuild Mar 4, 2024
7 checks passed
@caioolivv caioolivv deleted the wl_rebuild_opt branch March 4, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants