Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halo bias tests #73

Merged
merged 2 commits into from Jan 19, 2023
Merged

Halo bias tests #73

merged 2 commits into from Jan 19, 2023

Conversation

eduardojsbarroso
Copy link
Contributor

Finished the halo_bias objects tests. Found one error on function definition. This is ready to be merged,

@@ -207,7 +207,7 @@ _nc_halo_bias_st_spher_eval (NcHaloBias *biasf, NcHICosmo *cosmo, gdouble sigma
*
* Returns: A new #NcHaloBias.
*/
NcHaloBias *
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the only error I found

@@ -226,7 +226,7 @@ nc_halo_bias_st_spher_new (NcHaloMassFunction *mfp)
*
* Returns: A new #NcHaloBias.
*/
NcHaloBias *
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@@ -60,8 +60,8 @@ struct _NcHaloBiasSTSpher

GType nc_halo_bias_st_spher_get_type (void) G_GNUC_CONST;

NcHaloBias *nc_halo_bias_st_spher_new (NcHaloMassFunction *mfp);
NcHaloBias *nc_halo_bias_st_spher_new_full (NcHaloMassFunction *mfp, gdouble delta_c, gdouble a, gdouble p);
NcHaloBiasSTSpher *nc_halo_bias_st_spher_new (NcHaloMassFunction *mfp);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here

@vitenti vitenti merged commit 7e6b4f1 into master Jan 19, 2023
@vitenti vitenti deleted the mean_bias_tests branch November 9, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants