WL binned likelihood object #77

caioolivv · 2023-02-24T23:25:49Z

Implementing binned object to compare to unbinned and KDE methods.

…. Fixed leak in nc_galaxy_wl.

… wl_kde_likelihood

…g observable. Created new object class nc_galaxy_wl_ellipticity_kde and moved calculations from nc_galxy_wl to nc_galaxy_wl_ellipticity_kde. Introduced new method nc_galaxy_wl_dist_m2lnP_initial_prep. Edited Makefile.am, Makefile.in, ncm_cfg.c and numcosmo.h to accomodate changes. Changes have made calculations slower but results seem to be in line with previous version.

…ave fixed memory leak (?) issue on last commit

…s initially causing the segmentation fault.

… other related objects.

…elihood

… self->kde, epdf_bw_type stayed as FIXED instead of being recast as RoT.

…working on creating a NcmObjArray with the galaxy data belonging to each bin. Probably (certainly) very buggy.

coveralls · 2023-02-24T23:43:14Z

Coverage: 49.579% (+0.04%) from 49.534% when pulling 221b94f on wl_binned_likelihood into ac4bb4e on master.

…d peek_e_vec methods.

…y preparing dist object, reduced number of tests.

Keeping nc_galaxy_wl_ellipticity_kde updated on this branch for comparison with nc_galaxy_wl_ellipticity_binned

caioolivv · 2023-03-07T22:17:37Z

Warning is being thrown when compiling:

(process:427516): GLib-GObject-CRITICAL **: 19:06:42.435: g_param_spec_object: assertion 'g_type_is_a (object_type, G_TYPE_OBJECT)' failed

(process:427516): GLib-GObject-CRITICAL **: 19:06:42.435: validate_pspec_to_install: assertion 'G_IS_PARAM_SPEC (pspec)' failed

(process:427516): GLib-GObject-CRITICAL **: 19:06:42.435: g_param_spec_ref_sink: assertion 'G_IS_PARAM_SPEC (pspec)' failed

(process:427516): GLib-GObject-CRITICAL **: 19:06:42.435: g_param_spec_unref: assertion 'G_IS_PARAM_SPEC (pspec)' failed

I think it's being thrown when registering property PROP_BIN_OBS, but can't figure why bin_obs would not be NCM_TYPE_OBJ_ARRAY when I'm declaring it as NcmObjArray and then creating it with ncm_obj_array_new (). Any idea why this would happen @vitenti ?

caioolivv · 2023-03-11T04:34:22Z

Warning is being thrown when compiling:
(process:427516): GLib-GObject-CRITICAL **: 19:06:42.435: g_param_spec_object: assertion 'g_type_is_a (object_type, G_TYPE_OBJECT)' failed

(process:427516): GLib-GObject-CRITICAL **: 19:06:42.435: validate_pspec_to_install: assertion 'G_IS_PARAM_SPEC (pspec)' failed

(process:427516): GLib-GObject-CRITICAL **: 19:06:42.435: g_param_spec_ref_sink: assertion 'G_IS_PARAM_SPEC (pspec)' failed

(process:427516): GLib-GObject-CRITICAL **: 19:06:42.435: g_param_spec_unref: assertion 'G_IS_PARAM_SPEC (pspec)' failed
I think it's being thrown when registering property PROP_BIN_OBS, but can't figure why bin_obs would not be NCM_TYPE_OBJ_ARRAY when I'm declaring it as NcmObjArray and then creating it with ncm_obj_array_new (). Any idea why this would happen @vitenti ?

Previous warnings were caused because g_param_spec_boxed should be used for this property. Also, _ should not be used in properties names, so I fixed it.

…g gebin->binobs as NcmObjArray on initialization.

…nt instead of a float. Tests are all passing now.

vitenti

Change the copy write notice to include your name.

Caio Lima de Oliveira and others added 21 commits October 26, 2022 11:28

New method for likelihood utilizing KDE

32eccc7

Added necessary support to compute the galaxy wl likelihood using KDE…

e275aa5

…. Fixed leak in nc_galaxy_wl.

Cut galaxies with e,g < 0, e,g > 0.05

d17cc08

First working version of the KDE likelihood for WL.

46e1252

Fixed behavior for g_i < 0

fe31fcb

Better control of the border in the galaxy KDE.

20c41a5

Merge branch 'wl_kde_likelihood' of github.com:NumCosmo/NumCosmo into…

9ca2260

… wl_kde_likelihood

Merge branch 'master' into wl_kde_likelihood

a18f037

Merge branch 'master' into wl_kde_likelihood

bc168f1

Freeing s_kde and g_vec on _nc_galaxy_wl_dist_initial_prep seems to h…

5280f27

…ave fixed memory leak (?) issue on last commit

Fix's fix. Freeing the memory allocated to s_kde and g_vec is what wa…

55a065c

…s initially causing the segmentation fault.

Fixed indentation.

ec25345

Removed comments and added doc.

81864c5

Reorganizing internal of nc_galaxy_wl_ellipticity_kde. Indentation on…

2bf84ff

… other related objects.

Merge branch 'master' of github.com:NumCosmo/NumCosmo into wl_kde_lik…

d1e0821

…elihood

Fixed email and unnecessary variable.

eb285c6

Fixed object names on docs.

d2db921

Fixed numcosmo/lss/nc_galaxy_wl_ellipticity_kde.c bug. When resetting…

8b8ae5b

… self->kde, epdf_bw_type stayed as FIXED instead of being recast as RoT.

Merge branch 'master' into wl_kde_likelihood

dc4a507

First attempt at creating binned object for wl likelihood. Currently …

09144ac

…working on creating a NcmObjArray with the galaxy data belonging to each bin. Probably (certainly) very buggy.

Caio Lima de Oliveira added 8 commits February 27, 2023 20:35

First version of unit test for nc_galaxy_wl_ellipticity_kde.

d37f1e0

A few minor fixes. Still not functional

aa32ed6

Added lss/nc_galaxy_wl_ellipticity_kde to numcosmo.h and math/ncm_cfg.c

8ee9017

Removed old code necessary for debugging.

df06953

Fixed copyright notice, fixed reset of self->e_vec, added peek_kde an…

6e442eb

…d peek_e_vec methods.

Fixed file name when adding tests, fixed nc_distance_comoving error b…

abda1ba

…y preparing dist object, reduced number of tests.

Merge branch 'wl_kde_likelihood' into wl_binned_likelihood

e445166

Keeping nc_galaxy_wl_ellipticity_kde updated on this branch for comparison with nc_galaxy_wl_ellipticity_binned

Registered new object NcGalaxyWLEllipticityBinned

998c5a0

Changed approach to binning, fixed set_bin_obs, object is now compiling

109c53f

caioolivv self-assigned this Mar 8, 2023

Finished binned weak lensing object prototype

a94e0fb

caioolivv marked this pull request as ready for review March 11, 2023 04:31

caioolivv requested a review from vitenti March 11, 2023 04:31

Caio Lima de Oliveira and others added 5 commits March 15, 2023 14:58

Started implementation of unit test for wl_ellipticity_binned, settin…

72f6bee

…g gebin->binobs as NcmObjArray on initialization.

Debugging

752cae0

Fixed binning behaviour. Bug was caused by casting bin limits as an i…

b47662d

…nt instead of a float. Tests are all passing now.

Merge branch 'master' into wl_binned_likelihood

a283c61

Update nc_galaxy_wl.c

a3d4299

vitenti requested changes Mar 17, 2023

View reviewed changes

Fixed copyright notices

221b94f

vitenti merged commit 26493b8 into master Mar 19, 2023
6 checks passed

vitenti deleted the wl_binned_likelihood branch March 19, 2023 01:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WL binned likelihood object #77

WL binned likelihood object #77

caioolivv commented Feb 24, 2023

coveralls commented Feb 24, 2023 •

edited

caioolivv commented Mar 7, 2023

caioolivv commented Mar 11, 2023

vitenti left a comment

WL binned likelihood object #77

WL binned likelihood object #77

Conversation

caioolivv commented Feb 24, 2023

coveralls commented Feb 24, 2023 • edited

caioolivv commented Mar 7, 2023

caioolivv commented Mar 11, 2023

vitenti left a comment

Choose a reason for hiding this comment

coveralls commented Feb 24, 2023 •

edited