New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for python 3.4 #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I copied ExitStack from the contextlib standard library module.
Sure.
|
If ExitStack is not present (python < 3.3), ExitStack is loaded from existack.py
1 similar comment
Hello, now it uses contexter as a replacement, as suggested in the discussion for issue #4. Since I had to revert a few commits, the history looks a little messy. If you want, I can create a new branch and cherry-pick only the last commits, without the reverts. |
Awesome ! +1 |
Hi @davethecipo Sorry for the late answer.. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I made a few changes to support python 3.4. The biggest one is copying
ExitStack
from contexlib in order to replace contextlib.nested().I haven't tried this code but all tests pass.