Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for python 3.4 #5

Merged
merged 8 commits into from Apr 17, 2015
Merged

Support for python 3.4 #5

merged 8 commits into from Apr 17, 2015

Conversation

davethecipo
Copy link
Contributor

Hello,

I made a few changes to support python 3.4. The biggest one is copying ExitStack from contexlib in order to replace contextlib.nested().

I haven't tried this code but all tests pass.

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.65%) when pulling 12cdf61 on davethecipo:py34 into 6b42af4 on Numergy:master.

@davethecipo
Copy link
Contributor Author

Sure.

  1. Do you have a preference for the file name?
  2. What condition should be used? Maybe something like this?
try:
    from contextlib import ExitStack
except ImportError:
    from .NEW_FILE_NAME_HERE import ExitStack

If ExitStack is not present (python < 3.3), ExitStack is loaded from
existack.py
@coveralls
Copy link

Coverage Status

Coverage decreased (-9.42%) when pulling ca41d81 on davethecipo:py34 into 6b42af4 on Numergy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.0% when pulling bdc1142 on davethecipo:py34 into 6b42af4 on Numergy:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.0% when pulling bdc1142 on davethecipo:py34 into 6b42af4 on Numergy:master.

@davethecipo
Copy link
Contributor Author

Hello, now it uses contexter as a replacement, as suggested in the discussion for issue #4. Since I had to revert a few commits, the history looks a little messy. If you want, I can create a new branch and cherry-pick only the last commits, without the reverts.

@jpic
Copy link
Member

jpic commented Apr 16, 2015

Awesome !

+1

Sliim added a commit that referenced this pull request Apr 17, 2015
@Sliim Sliim merged commit f64012f into Numergy:master Apr 17, 2015
@Sliim
Copy link
Member

Sliim commented Apr 17, 2015

Hi @davethecipo

Sorry for the late answer.. Merged!
Thanks for your work 👍
Thanks @jpic for your review :)

@davethecipo davethecipo deleted the py34 branch April 18, 2015 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants