fix: restore cursor visibility in case of errors #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } catch (error) { | ||
| s.stop('The AI is analyzing your changes'); | ||
| throw error; | ||
| } |
There was a problem hiding this comment.
Change to finally block so we don't need to catch or re-throw the error.
There was a problem hiding this comment.
I changed it to finally block and keep the stop message the same in both cases.
| staged!.diff, | ||
| config.generate, | ||
| ); | ||
| let messages; |
There was a problem hiding this comment.
Isn't this type any?
|
Thanks for the PR. Hopefully we can revert this soon: natemoo-re/clack#106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
spinner.startfunction fromclack@promtspackage hides terminal cursor, in case of errors the cursor remains hidden. To fix this, I've added a call tospinner.stop()before throwing errors. This will unhide the cursor,