Add support for custom OpenAI URL #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's quite strange how variables carry varying connotations. And etc. Why not to keep everything in uppercase? |
Allows to run local OpenAI-compatible server. Since these local instances most likely lack proper certificates, allow using non-HTTPS endpoints as well. Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
abbra
force-pushed
the
custom-openai-intance
branch
from
f03fc3c
to
b6ded16
Compare
|
@toropanov thanks, I updated to use uppercase version for both. |
gondyb
reviewed
Mar 18, 2024
src/utils/config.ts
Outdated
| @@ -27,7 +27,7 @@ const configParsers = { | |||
| 'Please set your OpenAI API key via `aicommits config set OPENAI_KEY=<your token>`' | |||
| ); | |||
| } | |||
| parseAssert('OPENAI_KEY', key.startsWith('sk-'), 'Must start with "sk-"'); | |||
| parseAssert('OPENAI_KEY', /^((sk-|no_api_key){1}[a-zA-Z0-9]*)$/.test(key), 'Must start with "sk-" or "no_api_key"'); | |||
There was a problem hiding this comment.
can we completely remove this check? My OpenAI instance requires an API key which doesn't start by sk-, but still requires an API key.
There was a problem hiding this comment.
I can remove it in a separate commit.
The API key format is specific to a particular implementation and deployment of OPENAI API. There is no way to do common checks for it, so better to remove it at all and add some general note to the documentation instead. Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
|
I've created a new project with your options based on aicommits. If you're interested, please check it out. |
|
👍🏻 I also plan to do this, it is very useful. |
|
Anything blocking this PR? I'd like to attach aicommits to LM Studio so I can keep everything local to my machine 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to run local OpenAI-compatible server. Since these local instances most likely lack proper certificates, allow using non-HTTPS endpoints as well.