Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Plugin Override Function Capabilities #1240

Merged

Conversation

endoze
Copy link
Contributor

@endoze endoze commented Jun 19, 2022

In order to ensure that plugin configuration that is overridden with a
function instead of a table is still merged with the default plugin
configuration, this commit splits up the if/elseif/else statement in
lua/core/utils.lua.

This is necessary as we want to take the resulting table returned from
the override function and merge it with the default_table before setting
up the plugin.

Fixes this issue

In order to ensure that plugin configuration that is overridden with a
function instead of a table is still merged with the default plugin
configuration, this commit splits up the if/elseif/else statement in
lua/core/utils.lua.

This is necessary as we want to take the resulting table returned from
the override function and merge it with the default_table before setting
up the plugin.

Fixes [this issue](NvChad#1239)
@siduck siduck merged commit 2138c84 into NvChad:main Jun 19, 2022
@endoze endoze deleted the fix-plugin-override-function-capabilities branch June 21, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent change to core.utils.load_override broke using functions for plugin override
2 participants