Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev test custom user config #168

Closed
wants to merge 1 commit into from

Conversation

G-Rowell
Copy link
Contributor

Hi all,

This is related to this issue.

We are making custom user configs for NvChad, which don't interfere/merge-conflict

.gitignore won't work for this, as the file is comitted,
we use git update-index --assume-unchanged lua/custom.lua

This seems to be a working prototype, but I'm intending this to be a part of the discussion here
So feel free to comment, not certain this is ready to merge (but it is working!)

tl;dr: monkey set their own config to be banana coloured

@G-Rowell
Copy link
Contributor Author

Need to check if git update-index --assume-unchanged lua/custom.lua is persistent across each user's own copy of the branch

@Akianonymus
Copy link
Contributor

How about adding a custom.sample.lua to repo, not custom.lua

But, we will originally use custom.lua only. A check will be added if custom.lua is present for error handling

custom.sample.lua will contain all the configuration which are change able without breaking with core nvchad setup.

By all configuration, i mean vim options( enable dashboard or not ), mappings, etc

The sample custom config will contain the values which are set in nvchad by default.

So, even if user renames custom.sample.lua to custom.lua, should get default configs and then they can start messing with it .

@G-Rowell
Copy link
Contributor Author

MMmm I like it defs some good ideas,
why not keep it as custom.lua but comment out the sourcing/calling of this file in init.lua?

Though could keep some commented options as example,
could also have a wiki page listing options (or list breaking options/plugins not tune from within custom.lua

Think you have some good points! :)

@G-Rowell
Copy link
Contributor Author

Note for future me:
Seems like this may have an issue,
replicate:
modifiy custom.lua,
git status shows nothing,
git checkout main bring error due to custom.lua modify

@Akianonymus
Copy link
Contributor

Akianonymus commented Jul 20, 2021

Note for future me:
Seems like this may have an issue,
replicate:
modifiy custom.lua,
git status shows nothing,
git checkout main bring error due to custom.lua modify

One of the main reason i said custom.sample.lua was because of this, we won't to worry about it. And no need to worry about overwriting user custom.lua because we don't have custom.lua in this repo to begin with .

@G-Rowell
Copy link
Contributor Author

Note for future me:
Seems like this may have an issue,
replicate:
modifiy custom.lua,
git status shows nothing,
git checkout main bring error due to custom.lua modify

One of the main reason i said custom.sample.lua was because of this, we won't to worry about it. And no need to overwriting user custom.lua because we don't have custom.lua in this repo to begin with .

Yeah, think you've given wiser input than me
Ty Ty, let's have a look sometime 😄

@G-Rowell
Copy link
Contributor Author

G-Rowell commented Aug 2, 2021

Closing, this was a proof of concept and no longer needed.
There are some brilliant ideas from many contributors for a better implementation.

@G-Rowell G-Rowell closed this Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants