Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greatly improve terminal features! Persistent terminals #275

Merged
merged 3 commits into from
Aug 18, 2021

Conversation

G-Rowell
Copy link
Contributor

@G-Rowell G-Rowell commented Aug 18, 2021

Hi all,

(terms = NeoVim :terminals)

This is a PR to greatly improve our term functionality.
This can be summarised as now having persistent terms!
I particularly aim to never leave NeoVim when working, so this helps a lot in that sense!

Improvements:

  • Persistent terms with
    -- These can create as many terms as you wish (as they just generate a new term)
    -- <leader> + w for a window term
    -- <leader> + v for a vertical split term
    -- <leader> + h for a horizontal split term
    -- A newly created term will start in insert mode

  • Escape term mode with jk

  • Escape & hide term with JK

  • Bring them back with a Telescope picker terms
    -- <leader> + W (note, capital W, so technically <leader> + <shift> + w
    -- This runs :Telescope terms

  • Improved close buffer behavior generally (also enables hiding of terms to keep them persistent)

  • this also removes the ToggleTerm plugin, so you should run :PackerSync

Known issues / wishlist:

  • Auto start in insert mode when recovering one with the picker
  • Statusline appears in terms again, need to fix this
  • Improve picker for 100 columns terminal windows like I run (can't see the term buffer)
  • Recovering window terms doesn't always put it back on the bufferline, if you are in a split of a term it will go into that window

Tl;dr monkey can type cmatrix in terms now!

@G-Rowell G-Rowell requested review from Akianonymus and siduck and removed request for Akianonymus August 18, 2021 06:59
@G-Rowell G-Rowell self-assigned this Aug 18, 2021
@G-Rowell G-Rowell added this to the v1.0 milestone Aug 18, 2021
@G-Rowell G-Rowell added the enhancement New feature or request label Aug 18, 2021
@G-Rowell
Copy link
Contributor Author

Don't merge until I give the okay, I may be working on fixes

@G-Rowell
Copy link
Contributor Author

Tested & approved by @siduck76

@siduck
Copy link
Member

siduck commented Aug 18, 2021

waiting for @Akianonymus 's review and test!

@siduck siduck merged commit 575dc10 into NvChad:main Aug 18, 2021
wang-borong pushed a commit to wang-borong/NvChad that referenced this pull request Aug 18, 2021
* 'main' of https://github.com/siduck76/NvChad:
  added relativenumber option & statusline option (NvChad#279)
  add bg to Floating window
  Greatly improve terminal features! Persistent terminals (NvChad#275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants