Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Themes #263

Open
AntonPieper opened this issue Nov 23, 2023 · 3 comments
Open

Update GitHub Themes #263

AntonPieper opened this issue Nov 23, 2023 · 3 comments

Comments

@AntonPieper
Copy link

The current "github_dark" and "github_light" themes do not align with the actual GitHub Theme. Maybe it is time to update them (particularly the dark theme) to align with the VSCode GitHub Themes Extension default themes (GitHub Dark Default and GitHub Light Default). If the newer versions are too different, they could also be called "github_dark_default" and "github_light_default" respectively to match the VSCode extension's naming scheme.

@siduck
Copy link
Member

siduck commented Nov 23, 2023

prs are welcome

@AntonPieper
Copy link
Author

I have tried for a few hours now, the challenging part for me is figuring out what each base30 / base16 value actually represents. To me it seems like many values don't change anything because I am not using the full set of features of NvChad / don't know where to look. It would be nice if there was some example source code file where every color is used or additional information in the docs. Nonetheless I am very great ful for your work and I will keep trying to implement this revision of the GitHub theme

@siduck
Copy link
Member

siduck commented Nov 24, 2023

check the readme of this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants